Skip to content

Conversation

@NackUn
Copy link

@NackUn NackUn commented Feb 8, 2020

No description provided.

@NackUn NackUn added the Review Needed 리뷰어의 리뷰가 필요한 경우 label Feb 8, 2020
@NackUn NackUn requested a review from sport0102 February 8, 2020 04:10
@NackUn NackUn self-assigned this Feb 8, 2020
@NackUn NackUn requested review from shareitDOIK and removed request for sport0102 February 9, 2020 01:49
@wkdehdlr wkdehdlr self-requested a review February 11, 2020 22:36
Copy link

@wkdehdlr wkdehdlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦었네용 ㅠ

val a = upbitTicker?.accTradePrice24h ?: 0.0
val b = bithumbTicker?.accTradePrice24h ?: 0.0
val c = coinOneTicker?.accTradePrice24h ?: 0.0
val a = upbitTicker.accTradePrice24h

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a, b, c 보다는 명시적인 변수명이 좋아보입니다!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!
d0f1ad6

@wkdehdlr wkdehdlr added Answer Needed PR담당자의 응답이 필요한 경우 and removed Review Needed 리뷰어의 리뷰가 필요한 경우 labels Feb 11, 2020
@NackUn NackUn added Review Needed 리뷰어의 리뷰가 필요한 경우 and removed Answer Needed PR담당자의 응답이 필요한 경우 labels Feb 12, 2020
@NackUn NackUn requested a review from wkdehdlr February 12, 2020 13:38
@NackUn
Copy link
Author

NackUn commented Feb 12, 2020

model 클래스를 사용하는 각각 api, ui(ticker, detail) 에 두면 괜찮을까요??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Needed 리뷰어의 리뷰가 필요한 경우

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants